[#487][#488] Fix cloud2edge post-install hook, fix tour instructions. #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kafka usage is now the default. Signed-off-by: Carsten Lohmann <[email protected]>
Signed-off-by: Carsten Lohmann <[email protected]>
calohmn
commented
Aug 27, 2023
| @@ -63,27 +66,27 @@ The demo device's digital twin supports a temperature property which will be set | |||
| by means of the following command: | |||
|
|
|||
| {% clipboard %} | |||
| curl -i -u [email protected]:demo-secret -H 'application/json' --data-binary '{ | |||
| curl -i -k -u [email protected]:demo-secret -H 'application/json' --data-binary '{ | |||
There was a problem hiding this comment.
FYI: I've added the -k (i.e. --insecure) option here for now. Better would be to fetch the used CA cert beforehand (via kubectl get secret) and use that here instead. But it seems the CA cert is currently only set in a K8s secret if Kafka messaging is being used. That means a generic solution requires changes also to the Hono chart.
sophokles73
reviewed
Aug 28, 2023
calohmn
force-pushed
the
PR/fix_cloud2edge_post_install
branch
from
0fd241a
to
b0702a2
Compare
Using new REGISTRY_BASE_URL and HTTP_ADAPTER_BASE_URL environment variables that will contain either the secure or insecure endpoint base URL depending on the chart configuration. Signed-off-by: Carsten Lohmann <[email protected]>
Signed-off-by: Carsten Lohmann <[email protected]>
Signed-off-by: Carsten Lohmann <[email protected]>
calohmn
force-pushed
the
PR/fix_cloud2edge_post_install
branch
from
b0702a2
to
3cbabd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes these fixes:
Using new REGISTRY_BASE_URL and HTTP_ADAPTER_BASE_URL environment variables that will contain either the secure or insecure endpoint base URL depending on the chart configuration.
Kafka usage is now the default.