branch plugin-rpc-v2: use an IPC server instead of a process pipe
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node has a bug on Windows preventing us from using process pipes to communicate between processes. Instead we'll use a named pipe on Windows and a Unix Domain Socket on Unix-like platforms.
|
I could not push new commit to your branch from the PR in Theia's main repository, hence this PR... |
1 task
paul-marechal
commented
Jul 28, 2022
Comment on lines
+89
to
+108
| const onCloseEmitter = new Emitter<ChannelCloseEvent>(); | ||
| const onErrorEmitter = new Emitter<Error>(); | ||
| const onMessageEmitter = new Emitter<MessageProvider>(); | ||
| socket.once('close', () => onCloseEmitter.fire({ reason: 'socket closed' })); | ||
| socket.on('error', error => onErrorEmitter.fire(error)); | ||
| channel.onMessage(buffer => onMessageEmitter.fire(() => new Uint8ArrayReadBuffer(buffer))); | ||
| const rpc = new RPCProtocolImpl({ | ||
| getWriteBuffer: () => { | ||
| const writer = new Uint8ArrayWriteBuffer(); | ||
| writer.onCommit(buffer => channel.send(buffer)); | ||
| return writer; | ||
| }, | ||
| close: () => { | ||
| channel.dispose(); | ||
| socket.destroy(); | ||
| }, | ||
| onClose: onCloseEmitter.event, | ||
| onError: onErrorEmitter.event, | ||
| onMessage: onMessageEmitter.event, | ||
| }); |
There was a problem hiding this comment.
This looks sketchy, feel free to improve this part.
|
This is no longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node has a bug on Windows preventing us from using process pipes to
communicate between processes.
Instead we'll use a named pipe on Windows and a Unix Domain Socket on
Unix-like platforms.
What it does
How to test
Review checklist
Reminder for reviewers