Add support for MultiField on GPU #201

sbrdar · 2024-05-21T17:57:57Z

Add FieldSet functions for device memory management via Field
Add support for the copy-on-device of discontiguous host memory
Add support for MultiField on the device

…y-does-not-need-update

…e ...

…::Config()); 2) Implement the optional host memory pinning and the optional mapping of this pinned memory for faster device memory access

… fctest_functionspace

…kStructureColumns

…eport from FieldImpl - it is an Array thing

…though)

… test to deal with acc-present and acc-deviceptr

…rgument in Fortran

…f discontiguous data, so that device_stridesf had to be introduced

… pass

…est pass

…r it

…as into feature/gpu_discontiguous_data

…emory (with Willem)

…llem)

codecov-commenter · 2024-05-23T16:50:52Z

Codecov Report

Attention: Patch coverage is 66.37931% with 273 lines in your changes are missing coverage. Please review.

Project coverage is 79.78%. Comparing base (3bcbdb8) to head (33083ef).
Report is 39 commits behind head on develop.

Files	Patch %	Lines
src/atlas_f/field/atlas_FieldSet_module.fypp	2.56%	152 Missing ⚠️
src/atlas/field/detail/FieldInterface.cc	0.00%	21 Missing ⚠️
src/atlas/field/detail/MultiFieldInterface.cc	70.83%	21 Missing ⚠️
src/tests/field/test_multifield_ifs.cc	90.72%	14 Missing ⚠️
src/atlas/util/RegisterPointerInfo.cc	0.00%	11 Missing ⚠️
src/atlas_f/field/atlas_MultiField_module.fypp	68.75%	10 Missing ⚠️
src/atlas/array/native/NativeDataStore.h	82.00%	9 Missing ⚠️
src/atlas/array/native/NativeArray.cc	89.06%	7 Missing ⚠️
src/atlas/array/Array.h	0.00%	4 Missing ⚠️
src/atlas/array/ArraySpec.cc	69.23%	4 Missing ⚠️
... and 9 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #201      +/-   ##
===========================================
- Coverage    80.07%   79.78%   -0.29%     
===========================================
  Files          859      792      -67     
  Lines        63684    62656    -1028     
===========================================
- Hits         50995    49993    -1002     
+ Misses       12689    12663      -26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ames

…tatype, shape, variable_names

wdeconinck · 2024-10-07T11:16:19Z

This PR will be split up in different ones.

first up is Add MultiField to pack field allocations #229
then add GPU support via pluto
then update remaining features and resolve conflicts.

wdeconinck and others added 30 commits April 29, 2024 07:36

Add RegisterPointerInfo

a12114f

1) sync_host_device to skip unused fields; 2) xx-needs-update means y…

22d7fb7

…y-does-not-need-update

add FielSet cummulative gpu operations: allocate_device, update_devic…

b7c37d1

…e ...

Fix atlas_fctest_field_gpu_device with gt storage

3b582bc

Use standard CMake find_package(OpenACC) instead of handcrafted flags

e59fe9c

Trace GPU events when ATLAS_TRACE_MEMORY=1

d74086e

1) Pass a config argument from Field down to Array (defaulted to util…

e41689b

…::Config()); 2) Implement the optional host memory pinning and the optional mapping of this pinned memory for faster device memory access

Disable atlas_test_field_pinning, as test_field_pinning.cc not found

590d37d

Add copy of Config for Fortran

c2162f7

forgot to add unit test for pinning memory of Field

2f8f0d9

add -options- argument in functionspace%create_field; adapt unit test…

3003ce6

… fctest_functionspace

also add options in create_field called from atlas_functionspace_Bloc…

d6ac142

…kStructureColumns

trace report for Field with memory pinning; 2) remove pinnen memory r…

0548225

…eport from FieldImpl - it is an Array thing

enforced pinning via eckit::Resource (by Willem)

8fcecba

make the options argument pass down to ArrayDataStore

5f4b5f9

move host_memory booleans to ArrayDataStore

946fef6

Tidy, revert host_memory_pinning to NativeDataStore

1576efc

Fix test

9f64a4f

add thorough tests on memory pinning and mapping of Field

5c74b9c

a working c++ usage of field->device_data in ACC-deviceptr (not nice …

a6ba9c3

…though)

1) add field%device_data and Fortran API backend; 2) improve the unit…

76fa5ff

… test to deal with acc-present and acc-deviceptr

fix the unit test - remove external_acc_routine with device pointer a…

49ab5b8

…rgument in Fortran

bug fix in calling for device_data from Field_module.fypp (thx Willem)

cc2ad95

improve the Fortran unit test for wrapping of discontiguous data

ff2cb5f

strides on the device do not correspond to the device shape in case o…

20220b0

…f discontiguous data, so that device_stridesf had to be introduced

using cudaMemcpy2D to do strided copy of discontiguous data

f19e676

add c-test for wrapping discontiguous data (with Willem)

4d8ed39

update unit test for wrapping of the discontiguous data; fix test_field

cb13d32

bug fix in wrapping of discontiguous data; make unit test on wrapping…

744e68f

… pass

bug fix in wrapping discontiguous data to make Fortran and C++ unit t…

8d38b9d

…est pass

sbrdar added 12 commits May 17, 2024 20:28

1) turn fypp to F90; 2) add a Fortran unit test for MultiField

8c233c9

remove file

b6087cf

improve Fortran unit test for MultiField

798c4bd

add data access by array and index for MultiField plus a unit test fo…

1e15af0

…r it

make compile again

0ab9946

add device_data on FieldSet in Fortran API

c35c13b

bug fix, do not attempt the acc_map when da^C discontiguous

5f16f02

pass config through MultiField down to Array (with Willem)

96e2918

Merge branch 'feature/gpu_discontiguous_data' of github.com:ecmwf/atl…

baa4cd3

…as into feature/gpu_discontiguous_data

WrappedArray has to know if the device memory is mapped to the host m…

9570229

…emory (with Willem)

make compile on GH200 (by Willem)

8db9b44

make pinning work correctly; add tracing to Array cuda calls (with Wi…

33083ef

…llem)

sbrdar added 16 commits September 4, 2024 17:59

restructure MultiField construction (with Willem)

179e07d

fix MultiField constructor for C based only on datatype, shape, var_n…

f55c748

…ames

add MultiFieldCreatorArray - a generic MultiField constructor from da…

5d30f10

…tatype, shape, variable_names

MultiFieldCreatorIFS does not need this constructor

715125a

Config-constructor for MultiFieldCreatorArray

3d9b6e9

add problematic multifield-array test with config

6fe2801

Merge branch 'develop' into feature/gpu_discontiguous_data

e9546be

Merge branch 'develop' into feature/gpu_discontiguous_data

f216567

remove config argument in many Field and Array constructors

4f2092c

bug fix in the IFS field creator

b84a58a

bypass Intel compiler problem

7f33861

bug fix in MultiFieldCreatorArray

3153f92

fix MultiField Fortran API constructor to fall back to C-implementation

b666b4d

remove debug output

5f16559

remove debug output

946ed54

Merge branch 'develop' into feature/gpu_discontiguous_data

e84dc2e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for MultiField on GPU #201

Add support for MultiField on GPU #201

sbrdar commented May 21, 2024

codecov-commenter commented May 23, 2024

wdeconinck commented Oct 7, 2024

Add support for MultiField on GPU #201

Are you sure you want to change the base?

Add support for MultiField on GPU #201

Conversation

sbrdar commented May 21, 2024

codecov-commenter commented May 23, 2024

Codecov Report

wdeconinck commented Oct 7, 2024