Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor util::pack_vector_fields to use array::ArrayViewVariant #226

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Refactor util::pack_vector_fields to use array::ArrayViewVariant #226

wants to merge 23 commits into from

Conversation

odlomax
Copy link
Contributor

@odlomax odlomax commented Sep 25, 2024 •
edited
Loading

This PR refactors util::pack_vector_fields to use std::variant<ArrayViews...> with std::visit, as opposed to nested switch statements to resolve the possible Value types and Rank values for different arrays.

I also found it beneficial to refactor array::make_view_variant such that it produces either a variant of const or a variant of non- const ArrayView types.

This PR needs #220 and #224 to be merged first.

@odlomax
Added array view variant class and tests.
436b36b
@odlomax
Merge branch 'develop' into feature/array_view_variant
44d7f2b
@odlomax
Merge branch 'develop' into feature/array_view_variant
97eadff
@odlomax
Moved make_view_variant into array namespace.
30a2bc3
@odlomax
Refactored ArrayViewVariant methods.
95d9977
@odlomax
More refactoring.
c3638d3
@odlomax
Updated test.
cbf7818
@odlomax
Attempting to address gnu 7.3 compiler errors.
b6ff4af
@odlomax
Typos in comments.
6db4f83
@odlomax
Merge branch 'develop' into feature/array_view_variant
73d990f
@odlomax
Added missing EXPECTs in test.
f4d3697
@odlomax
Merge branch 'develop' into feature/array_view_variant
b608818
@odlomax
Refactored detial::VariantHelper template.
ed15c84
@odlomax
added vector field packing the spherical vector interpolation.
48e727a
@odlomax
Fixed ordering of fixup_halos and halo_exhange in StructuredColumns.cc
5784ea2
@odlomax
Merged bugfix into feature branch.
d87c9af
@odlomax
Ready for review.
62c41d8
@odlomax
Delete src/atlas/functionspace/detail/StructuredColumns.cc.orig
b2b41fe
@odlomax
Reverted random test changes.
3d4308c
@odlomax
Merge branch 'feature/array_view_variant' into feature/refactor_pack_…
62b0041 
…vector_fields
@odlomax
Refactored ArrayViewVariant into const and non-const types.
55cfbe4
@odlomax
Refactored pack_vector_fields to use ArrayViewVariant.
1f4b191
This was referenced Sep 25, 2024
Merged
Open
@wdeconinck
Copy link
Member

@odlomax Ready for rebase / conflict resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odlomax @wdeconinck