Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include uvRelativeToGrid as read GRIB key by default #379

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

blaylockbk
Copy link
Contributor

This PR resolves #378. I hope you will consider including uvRelativeToGrid as a default GRIB key to include in the DataArray attributes as this is a necessary piece of information when interpreting the U and V wind vector orientation.

@FussyDuck
Copy link

FussyDuck commented May 17, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.39%. Comparing base (c9d7ef9) to head (2d06f22).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   41.39%   41.39%           
=======================================
  Files          26       26           
  Lines        2184     2184           
  Branches      285      285           
=======================================
  Hits          904      904           
  Misses       1280     1280           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iainrussell iainrussell merged commit 59e5b3a into ecmwf:master Jul 19, 2024
90 checks passed
@iainrussell
Copy link
Member

Thanks @blaylockbk, I've merged it for this afternoon's release of 0.9.14.0!

@blaylockbk
Copy link
Contributor Author

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request that uvRelativeToGrid GRIB key be read by default
4 participants