-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding visual effect for tree map box #69
Comments
Hi @raashika03 I understand the frustration, that why I reduce the size of the tree to not 100% of the view height, so we can grab after the tree. Still, your point is valid as we do not know when dragging inside the tree that we are not dragging the page but the tree ... which doesn't move as not zoomed enough :/ I understand your solution but I think this issue could be solve in an other way: P.S: I agree that if we zoom so the whole viewed area is the tree then we cannot escape it, the buttons would not solve the issue completely as if they are not visible at this moment we are still trapped. |
I wasn't very clear about the border effect I showed in the animation sorry, it is something that is for now not available but could be implemented by you, and would then be available on any screen/os. Implementing such effect would also allow you to dive into the code of the tree, and find where to add the listeners. |
OK I'll implement this.
What does listeners means here? Are you linking with screen reader thing(out of box:/)? |
I did not understood your second question, but to answer the first I was talking about listener in the d3js code. |
I understood second one too by your answer to first.
Ok👍 |
Thank you sooo much @raashika03 & @bryan-brancotte for diving into the details of this usability issue! 🚀 As @bryan-brancotte suggested, it will indeed be very nice if you, @raashika03 work on the implementation with help of @bryan-brancotte's suggestions. I'm assigning it and looking forward! |
A first attempt with pure css have been tried in #95 but does not do the trick. As far as I know there is no solution without javascript. |
Oki @bryan-brancotte I'll now go for listeners. |
I guess this is now a duplicate of #201 ? The issue now is to make the resizer work on mobile, right? Or the visual effect is still a desired feature? @bryan-brancotte |
adding a resize feature in the tree map box will be a good idea I think, cause while scrolling through the browser in smaller screens like in phone, tree map box acquires almost the whole screen leaving some spaces below and above it, and only those spaces can be used for scrolling which makes it difficult for the user to scroll down or up.
Only red area marked can be used for scrolling down, which seems frustrating, I felt this when I used Edam browser in the phone for the first time,
I thought my phone isn't working :( took me few minutes to realise that box isn't scrollable like other elements. Even scrolling using vertical scrollbar isn't at all feasible in phone at least because of its less width by default.
So a decrease option to minimise the box size( not to zero) will be nice.
It can be done something similar to what's there for applications in an os, Resizing using cursor at the corners.
Another way can be to provide a button kind of thing like in some PDF reader to change size to 50%, 100%, 10%... For the tree map box only.
I think 1 will work in desktop version only, so option 2 can be used which will be made to appear for screens of size less than a particular value.
Refreshing is also difficult currently.
What are your views @bryan-brancotte @matuskalas @hmenager :-)
The text was updated successfully, but these errors were encountered: