Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grabbing cursor for the tree map #179

Closed
wants to merge 3 commits into from
Closed

Grabbing cursor for the tree map #179

wants to merge 3 commits into from

Conversation

raashika03
Copy link
Contributor

Checklist

  • I indicated which issue (if any) is closed with this PR using closing keywords
  • I only changed lines related to my PR (no bulk reformatting)
  • I indicated the source and check the license if I re-use code, or I did not re-use code
  • I made my best to solve only one issue in this PR, or explain why multi had to be solved at once.

Issue

close #105

PR:
close #129

Details

grabbing-cursor.mp4

Copy link
Member

@bryan-brancotte bryan-brancotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

This does not solve #105 as the pointer is always in grabbing state, not only when grabbing and moving the tree around

@raashika03
Copy link
Contributor Author

raashika03 commented May 10, 2021

No please review it closely. It's in pointer state when nodes are clickable. In rest other condition(where grabbing/moving the tree is possible) it's in grabbing state.

@bryan-brancotte
Copy link
Member

In rest other condition(where grabbing/moving the tree is possible) it's in grabbing state.

I agree with you, the cursor grabbing is the one use by default. It is used even when not grabbing the tree and that is a UX issue.

Solving #105 will also solve #69, and reciprocally as both want to provide a feedback to the user and (s)he is moving the tree.

@raashika03
Copy link
Contributor Author

It is used even when not grabbing the tree and that is a UX issue.

can you show me the area where this's happening. I see wherever grabbing cursor is present grabbing is possible there and we can move the tree map using that location.

Do you mean that grabbing should appear only when cursor is on the tree map.
outside tree map it should be default one. then at the nodes pointer will be there.

But grabbing is working even outside tree map.
@bryan-brancotte please clarify.

@raashika03
Copy link
Contributor Author

grabbing is possible for the whole svg. Ok this you mean by UX issue.

So, this issue should have grabbing cursor only on the tree?

@raashika03 raashika03 closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propose changing the mouse cursor to a hand when moving the tree around
2 participants