Dark Mode Plug-In Issue

[mekaspencer31]

Hi, when I go to put in the hex colors for dark mode it does not make the change to the background "BG" or Text does not change the same color as white.

[eddiesigner]

Hi,

are you sure that the layers of your document are actually using those colors variables? The plugin ignores colors that are not Color Variables or Color Assets. If not then you have to assign the proper Color Variable or Color Asset in the color inspector for every layer.

https://github.com/eddiesigner/sketch-dark-mode/wiki/How-to-use-Sketch-Dark-Mode#2-use-your-colors-in-the-layers-of-your-document

[mekaspencer31]

[image: Screen Shot 2021-03-08 at 10.51.16 AM.png] [image: Screen Shot 2021-03-08 at 10.53.26 AM.png] Yes if you can see here that I have the background color set to BG #ffffff but when I update to dark mode it doesn't change to the desired color I want.

…

On Mon, Mar 8, 2021 at 7:43 AM Eduardo Gómez ***@***.***> wrote: Hi, are you sure that the layers of your document are actually using those colors variables? The plugin ignores colors that are not Color Variables or Color Assets. If not then you have to assign the proper Color Variable or Color Asset in the color inspector for every layer. <https://camo.githubusercontent.com/058daea2fe8e0222680ac9092b500e351283a3e9d00a92d9e2dc6eff48c35692/68747470733a2f2f7265732e636c6f7564696e6172792e636f6d2f656465762f696d6167652f75706c6f61642f76313538373239333231362f736b657463682d6461726b2d6d6f64652f53637265656e73686f745f323032302d30342d31395f61745f31322e34352e33382e706e67> https://github.com/eddiesigner/sketch-dark-mode/wiki/How-to-use-Sketch-Dark-Mode#2-use-your-colors-in-the-layers-of-your-document — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATDLWBEDEZPYV5VGA5WAWKTTCTBARANCNFSM4YWAQVUA> .

[eddiesigner]

I can't see the image, please try to upload it directly through Github.
What version of Sketch are you using?

[mekaspencer31]

Oh yes my apologies. Here are the images I tried to upload earlier.

[eddiesigner]

It looks good to me, please make sure to save the color palette and also your document changes. After that you can generate the dark mode version of your Artboard or your current Page by running one of the plugin commands: https://github.com/eddiesigner/sketch-dark-mode/wiki/How-to-use-Sketch-Dark-Mode#4-generate-the-dark-mode-version-of-your-design

[mekaspencer31]

But it's not changing the colors to the dark mode colors for BG and the blue body copy.

[eddiesigner]

That means that it works with the rest of the colors? I think the issue is because you have repeated colors. Blue Background, Blue Bar and Blue Copy are the same. You should try to reorganise your colors and remove the repeated ones because you don't need them after all, you can create a single color nammed Blue or something. Also you should consider removing Text because is the same color in dark mode.

Please remove all the repeated colors (Text as well) and try again.

[mekaspencer31]

Still doesn't work. It's actually made it worse. please see my screen recording here. This is a link to my dropbox since the 1 min video is huge. https://www.dropbox.com/sh/u45xgukvffczylx/AABcc9gZZNnMORnm07leJfFva?dl=0

[eddiesigner]

That happens because you still have two repeated colors: blue-bg and body-copy.

At the moment you can't have repeated colors even if they have a different name, this is because the only info I can get from layers styles is the hex color value, so internally the plugin searches for that specific value and replaces it with the dark color value, if you have two or more repeated colors then the plugin always convert one of them correctly but not all of them.

Usually this is not a problem because normally in a theme color palette you only have unique colors. Actually I wonder why you want to have the same color twice in light mode and use a different color for each of them in dark mode, normally you want to have a 1:1 mapping to make your design more consistent.

I would suggest to keep only one variation of that blue color.

I will see if I can come up with a solution for this limitation as soon as I have some free time.

[isax5]

I'm having the same issue, I have a few colors that are the same (code) depending if the color is dynamic or not, so I can't give the behavior a want