Import error: kops cluster with external policies

[rmgpinto]

I'm trying to import an existing cluster with external_policies defined, but I get:

provider.terraform-provider-kops_v1.20.0-beta.2: 2021/07/12 21:57:24 [ERR] Error writing fields: external_policies.node.1: '': source data must be an array or slice, got string: timestamp=2021-07-12T21:57:24.554+0100

I have something similar to this:

spec:
  externalPolicies:
    node:
    - arn:aws:iam::123456789000:policy/test-policy-1
    - arn:aws:iam::123456789000:policy/test-policy-2

[eddycharly]

What version are you using ?

I will test it tomorrow, expansion and flattening code looks correct but i fear that terraform only supports maps of primitive types https://github.com/hashicorp/terraform-plugin-sdk/blob/5f0e47111e779cb308990590c18d0ed547f0dd37/helper/schema/schema.go#L143-L151

If it's really the case i will find a workaround.

[rmgpinto]

Thanks for the quick reply. Latest version: terraform-provider-kops_v1.20.0-beta.2

[eddycharly]

It looks like there is an open issue from 2016 hashicorp/terraform-plugin-sdk#62

I will look into it tomorrow… maybe changing the map by a list with a key attribute 🤔

Fortunately the number of affected properties is pretty low.

[eddycharly]

external_policy {
  key = node
  value = [ arn1, arn2, etc …. ]
}

[rmgpinto]

Hi @eddycharly, any news on this? Thanks

[eddycharly]

Hey @rmgpinto I confirmed the issue and added an option in the provider to setup a cloud api mock so that i can write integration tests for such cases.

Now i'm going to start fixing it 🤞

[eddycharly]

It looks like #287 is fixing it.

At least, it doesn't complain when parsing tf code containing:

  external_policies {
    key = "node"
    value = [
      "arn:aws:iam::123456789000:policy/test-policy-1",
      "arn:aws:iam::123456789000:policy/test-policy-2"
    ]
  }

[rmgpinto]

Great, I'll test once it's released.

[eddycharly]

Would it be ok to test it with a 1.21 alpha release ?

[rmgpinto]

Yes, no problem.

…

On Thu, 15 Jul 2021 at 09:58 eddycharly ***@***.***> wrote: Would it be ok to test it with a 1.21 alpha release ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#282 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAGACFHDUBCQR3WXIPOV3DTX2PMZANCNFSM5AHTKLZA> .

[eddycharly]

Perfect, v1.21.0-alpha.3 is being built, it should be available in a couple of minutes.

[rmgpinto]

LGTM, thanks