fix: make zone in subnet optional #921
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ederst
force-pushed
the
do-not-require-subnet-zone
branch
from
9862073
to
41c022f
Compare
ederst
force-pushed
the
do-not-require-subnet-zone
branch
from
6981fb4
to
f36cb04
Compare
This makes setting `zone` in the `ClusterSubnetSpec` optional. Technically, kOps does not require this to be set as it will also include the `zones` from the `InstanceGroupSpec`.
ederst
force-pushed
the
do-not-require-subnet-zone
branch
from
f36cb04
to
ed6c3d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes setting
zonein theClusterSubnetSpecoptional.Technically, kOps does not require this to be set as it will also include the
zonesfrom theInstanceGroupSpec:https://github.com/kubernetes/kops/blob/43cc54b2b1fcd768c7c4992989123541421e25a2/pkg/apis/kops/model/utils.go#L36-L50
fixes: #918