Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform][AS4625-54P][AS5835-54X][AS9726-32D] Fix pytest test_psu.py::TestPsuApi failed. #241

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

tigerfu000
Copy link

Why I did it

  • Test platform_tests/api/test_psu.py::TestPsuApi is failed.
    • For AS4625-54P, AS5835-54X, and AS9726-32D:

      • Test test_led is failed.
    • For AS5835-54X:

      • Test test_get_revision and test_temperature are failed.

How I did it

  • For AS4625-54P, AS5835-54X, and AS9726-32D:

    • test_led:
      • Add "controllable": false for psus in platform.json to skip the test since PSU status LED is controlled by hardware.
  • For AS5835-54X:

    • test_get_revision:

      • Implement API get_revision() by referring to other PDDF platforms.
        • PSU does not support PMBus MFR_REVISION(9Bh), so just return 'N/A'.
    • test_temperature:

      • Implement API get_temperature_high_threshold() by referring to other PDDF platforms.

How to verify it

  • Run pytest
    • test_get_revision and test_temperature are pass.
    • test_led is skipped.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

@PJHsieh PJHsieh merged commit 55d7188 into edge-core:202311.0 Oct 8, 2024
1 check passed
@tigerfu000 tigerfu000 deleted the 2311.0.psu branch October 8, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants