Skip to content

Commit

Permalink
Revert changes to CSI driver charts
Browse files Browse the repository at this point in the history
These changes will be made once they are release in the upstream repos.
  • Loading branch information
derpsteb committed Jan 12, 2023
1 parent 52607c5 commit 003593f
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ spec:
- "--allow-empty-cloud-config={{ .Values.node.allowEmptyCloudConfig }}"
- "--support-zone={{ .Values.node.supportZone }}"
- "--get-node-info-from-labels={{ .Values.linux.getNodeInfoFromLabels }}"
- "--kms-addr=keyservice.{{ .Values.node.keyserviceNamespace | default .Release.Namespace }}:{{ .Values.global.keyservicePort }}"
- "--kms-addr=kms.{{ .Values.node.kmsNamespace | default .Release.Namespace }}:{{ .Values.node.kmsPort }}"
ports:
- containerPort: {{ .Values.node.livenessProbe.healthPort }}
name: healthz
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ node:
logLevel: 5
livenessProbe:
healthPort: 29603
keyserviceNamespace: "kube-system"
kmsPort: "9000"
kmsNamespace: "kube-system"

snapshot:
enabled: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ spec:
- "--v=5"
- "--endpoint=unix:/csi/csi.sock"
- "--run-controller-service=false"
- "--kms-addr=keyservice.{{ .Values.csiNode.keyserviceNamespace | default .Release.Namespace }}:{{ .Values.global.keyservicePort }}"
- "--kms-addr=kms.{{ .Values.csiNode.kmsNamespace | default .Release.Namespace }}:{{ .Values.csiNode.kmsPort }}"
securityContext:
privileged: true
volumeMounts:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ csiController:
runOnControlPlane: true

csiNode:
keyserviceNamespace: "kube-system"
kmsPort: "9000"
kmsNamespace: "kube-system"

createStorageClass: true
4 changes: 2 additions & 2 deletions cli/internal/helm/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ func (i *ChartLoader) loadConstellationServicesValues(config *config.Config, mas

values["azuredisk-csi-driver"] = map[string]any{
"node": map[string]any{
"keyserviceNamespace": "", // empty namespace means we use the release namespace
"kmsNamespace": "", // empty namespace means we use the release namespace
},
}

Expand All @@ -445,7 +445,7 @@ func (i *ChartLoader) loadConstellationServicesValues(config *config.Config, mas

values["gcp-compute-persistent-disk-csi-driver"] = map[string]any{
"csiNode": map[string]any{
"keyserviceNamespace": "", // empty namespace means we use the release namespace
"kmsNamespace": "", // empty namespace means we use the release namespace
},
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ spec:
- "--allow-empty-cloud-config=true"
- "--support-zone=true"
- "--get-node-info-from-labels=false"
- "--kms-addr=keyservice.testNamespace:9000"
- "--kms-addr=kms.testNamespace:9000"
ports:
- containerPort: 29603
name: healthz
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ spec:
- "--v=5"
- "--endpoint=unix:/csi/csi.sock"
- "--run-controller-service=false"
- "--kms-addr=keyservice.testNamespace:9000"
- "--kms-addr=kms.testNamespace:9000"
securityContext:
privileged: true
volumeMounts:
Expand Down

0 comments on commit 003593f

Please sign in to comment.