cli: update config migration to migrate v3 -> v4 (#2166)

edgelesssys · Aug 4, 2023 · 15bb958 · 15bb958
1 parent d1ace13
commit 15bb958
Show file tree

Hide file tree

Showing 4 changed files with 498 additions and 8 deletions.
diff --git a/cli/internal/cmd/BUILD.bazel b/cli/internal/cmd/BUILD.bazel
@@ -65,6 +65,7 @@ go_library(
         "//internal/compatibility",
         "//internal/config",
         "//internal/config/instancetypes",
+        "//internal/config/migration",
         "//internal/constants",
         "//internal/crypto",
         "//internal/file",

diff --git a/cli/internal/cmd/configmigrate.go b/cli/internal/cmd/configmigrate.go
@@ -10,6 +10,7 @@ import (
 	"fmt"
 
 	"github.com/edgelesssys/constellation/v2/internal/config"
+	"github.com/edgelesssys/constellation/v2/internal/config/migration"
 	"github.com/edgelesssys/constellation/v2/internal/constants"
 	"github.com/edgelesssys/constellation/v2/internal/file"
 	"github.com/spf13/afero"
@@ -33,19 +34,24 @@ func runConfigMigrate(cmd *cobra.Command, _ []string) error {
 }
 
 func configMigrate(cmd *cobra.Command, handler file.Handler) error {
-	// Make sure we are reading a v2 config
+	// Make sure we are reading a v3 config
 	var cfgVersion struct {
 		Version string `yaml:"version"`
 	}
 	if err := handler.ReadYAML(constants.ConfigFilename, &cfgVersion); err != nil {
 		return err
 	}
 
-	// TODO(malt3): add migration from v3 to v4
 	switch cfgVersion.Version {
 	case config.Version4:
 		cmd.Printf("Config already at version %s, nothing to do\n", config.Version4)
 		return nil
+	case migration.Version3:
+		if err := migration.V3ToV4(constants.ConfigFilename, handler); err != nil {
+			return fmt.Errorf("migrating config: %w", err)
+		}
+		cmd.Printf("Successfully migrated config to %s\n", config.Version4)
+		return nil
 	default:
 		return fmt.Errorf("cannot convert config version %s to %s", cfgVersion.Version, config.Version4)
 	}

diff --git a/internal/config/migration/BUILD.bazel b/internal/config/migration/BUILD.bazel
@@ -5,5 +5,12 @@ go_library(
     srcs = ["migration.go"],
     importpath = "github.com/edgelesssys/constellation/v2/internal/config/migration",
     visibility = ["//:__subpackages__"],
-    deps = ["//internal/file"],
+    deps = [
+        "//internal/attestation/idkeydigest",
+        "//internal/attestation/measurements",
+        "//internal/config",
+        "//internal/file",
+        "//internal/role",
+        "//internal/semver",
+    ],
 )