Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix Terraform resource group dependencies on Azure #1048

Merged
merged 1 commit into from
Jan 20, 2023
Merged

cli: fix Terraform resource group dependencies on Azure #1048

merged 1 commit into from
Jan 20, 2023

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jan 20, 2023 •
edited
Loading

Proposed change(s)

  • Fixing (creating) dependencies between Terraform resources for Azure IAM creation. This should prevent the 404's occasionally happening before.

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@msanft msanft added the bug fix Fixing a bug label Jan 20, 2023
@msanft msanft added this to the v.2.5.0 milestone Jan 20, 2023
@netlify
Copy link

netlify bot commented Jan 20, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit b3e038f
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63ca9b1fdbbe480009c32106

3u13r
3u13r approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katexochen katexochen changed the title cli: fix Terraform dependencies cli: fix Terraform resource group dependencies Jan 20, 2023
@3u13r 3u13r merged commit b864826 into main Jan 20, 2023
@3u13r 3u13r deleted the fix/terraformIAM branch January 20, 2023 18:00
@thomasten thomasten changed the title cli: fix Terraform resource group dependencies cli: fix Terraform resource group dependencies on Azure Jan 24, 2023
msanft added a commit that referenced this pull request Feb 6, 2023
@msanft
cli: fix Terraform resource group dependencies (#1048)
e163038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@3u13r 3u13r 3u13r approved these changes

Assignees
No one assigned
Labels
bug fix Fixing a bug
Projects
None yet
Milestone
v.2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msanft @3u13r @katexochen