cli: option to disable spinner via environment variable #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Kammel <[email protected]>
✅ Deploy Preview for constellation-docs canceled.
|
katexochen
reviewed
Feb 16, 2023
| @@ -37,7 +37,10 @@ func NewTerminateCmd() *cobra.Command { | |||
| // runTerminate runs the terminate command. | |||
| func runTerminate(cmd *cobra.Command, args []string) error { | |||
| fileHandler := file.NewHandler(afero.NewOsFs()) | |||
| spinner := newSpinner(cmd.ErrOrStderr()) | |||
| spinner, err := newSpinnerOrStderr(cmd) | |||
There was a problem hiding this comment.
Should we remove the newSpinner funciton so this cannot happen again? The code could just be inlined into the newSpinnerOrStderr function.
There was a problem hiding this comment.
I checked this. newSpinner is used quite a few times in spinner_test as well. Inlining this everywhere is probably not the right call.
The cleaner solution IMO would be to have spinner in its own package and export only required functions.
There was a problem hiding this comment.
I will refactor this in another PR.
daniel-weisse
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
CONSTELL_NO_SPINNERenvironment variable. Main motivation is to automatically skip waiting times in asciinema recordingsconstellation terminatespinner to honordebugflag and newCONSTELL_NO_SPINNERenvironment variableChecklist