Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix incorrect output for single worker/control-plane clusters #1209

Merged
merged 1 commit into from
Feb 17, 2023
Merged

cli: fix incorrect output for single worker/control-plane clusters #1209

merged 1 commit into from
Feb 17, 2023

Conversation

daniel-weisse
Copy link
Member

Proposed change(s)

  • Fix incorrect pluralization of nodes during the constellation create command when creating clusters with only 1 control-plane/worker node
  • Fix incorrect control-planes string to control-plane

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@daniel-weisse daniel-weisse added the bug fix Fixing a bug label Feb 16, 2023
@daniel-weisse daniel-weisse added this to the v2.6.0 milestone Feb 16, 2023
@netlify
Copy link

netlify bot commented Feb 16, 2023

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 330ecae
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63ee40b03fe61c0008c83969

@daniel-weisse daniel-weisse merged commit d90828c into main Feb 17, 2023
@daniel-weisse daniel-weisse deleted the fix/cli/node-numbers branch February 17, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derpsteb derpsteb derpsteb approved these changes

@katexochen katexochen Awaiting requested review from katexochen

Assignees
No one assigned
Labels
bug fix Fixing a bug
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-weisse @derpsteb