-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: retry on connection refused #1245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
derpsteb
reviewed
Feb 21, 2023
derpsteb
approved these changes
Feb 21, 2023
Doesn't seem to be related to this PR, but https://github.com/edgelesssys/constellation/actions/runs/4234338625/jobs/7356490507#step:9:3468 |
katexochen
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
katexochen
added
the
needs backport
This PR needs to be backported to a previous release
label
Feb 22, 2023
thomasten
approved these changes
Feb 22, 2023
3u13r
force-pushed
the
fix/helmRetrierAWS
branch
from
February 22, 2023 08:32
9e08536
to
576bf41
Compare
3u13r
force-pushed
the
fix/helmRetrierAWS
branch
from
February 22, 2023 08:49
576bf41
to
c9da251
Compare
derpsteb
pushed a commit
that referenced
this pull request
Feb 22, 2023
* bootstrapper: directly return kubewaiter error * helm: retry on connection refused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Problem:
constellation init
fails with:Detailed description:
What is interesting that after kubeadm init we have an explicit kubewaiter, which waits until it can list all K8s namespaces using the kubeclient and further kubeclient requests such as annotating the current node. But the execution of the first helm command fails.
The kubeclient automatically retries on almost all error cases. The helm client just on timeout errors (which the error we see is not, it is a "connection refused" error).
During all those requests mentioned above all targets (i.e. nodes) are unhealthy. This means that the AWS LB "fails open", routing to all targets.
This becomes most apparent on AWS since the switch from unhealthy to healthy takes at least 20 seconds. On GCP and Azure it should take 2-5.
Checklist