Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iam: assign uami role to base resource group #1247

Merged
merged 2 commits into from
Feb 22, 2023
Merged

iam: assign uami role to base resource group #1247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d6a3fd
iam: assign uami role to base resource group
3u13r Feb 21, 2023
e18d8db
fixup: also change app registration
3u13r Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cli/internal/terraform/terraform/iam/azure/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ resource "azurerm_user_assigned_identity" "identity_uami" {

# Assign roles to managed identity
resource "azurerm_role_assignment" "virtual_machine_contributor_role" {
scope = azurerm_resource_group.identity_resource_group.id
scope = azurerm_resource_group.base_resource_group.id
role_definition_name = "Virtual Machine Contributor"
principal_id = azurerm_user_assigned_identity.identity_uami.principal_id
}

resource "azurerm_role_assignment" "application_insights_component_contributor_role" {
scope = azurerm_resource_group.identity_resource_group.id
scope = azurerm_resource_group.base_resource_group.id
role_definition_name = "Application Insights Component Contributor"
principal_id = azurerm_user_assigned_identity.identity_uami.principal_id
}
Expand All @@ -73,7 +73,7 @@ resource "azuread_service_principal" "application_principal" {

# Set identity as base resource group owner
resource "azurerm_role_assignment" "owner_role" {
scope = azurerm_resource_group.identity_resource_group.id
scope = azurerm_resource_group.base_resource_group.id
role_definition_name = "Owner"
principal_id = azuread_service_principal.application_principal.object_id
}
Expand Down