-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attestation: add options to the EnforceIDKeyDigest
config field to enable Microsoft Azure Attestation fallback when verifying AMD SNP-SEV id key digest
#1257
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
6a55d5d
to
22766f0
Compare
c8ca59a
to
dc385b9
Compare
Just a heads-up: This branch should be rebased before merge and bazel build files should be generated. |
// EnforceIDKeyDigest defines the behavior of the validator when the ID key digest is not found in the expected list. | ||
type EnforceIDKeyDigest uint32 | ||
|
||
// TODO: Decide on final value naming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also think about renaming the key, but not sure what this means for backwards compat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be a breaking change from my pov. Maybe we can rename it when implementing #1436?
For that one we will need migration docs/code anyways.
EDIT: Oh. This requires migration docs/code already :D
04ed391
to
4cdb17e
Compare
990cb4d
to
eee1dcf
Compare
02433b0
to
0e110a9
Compare
Did a bunch of manual testing, but there is also this e2e test: https://github.com/edgelesssys/constellation/actions/runs/4417455739 |
742a421
to
05485cb
Compare
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
c2b1177
to
cbe07d1
Compare
Signed-off-by: Daniel Weiße <[email protected]>
EnforceIDKeyDigest
config field to enable Microsoft Azure Attestation fallback when verifying AMD SNP-SEV id key digest
Proposed change(s)
EnforceIDKeyDigest
option in the Constellation config from boolean to an enum. The following values are available (naming not final, looking for feedback/suggestions):StrictChecking
: requires the IDKeyDigest of the node to be in the list of trusted IDKeyDigests, error otherwiseMAAFallback
: if a node's IDKeyDigest is not in the list of trusted digests, MAA is used to verify the SNP properties of the VM.WarnOnly
: emit a warning, but accept IDKeyDigests not in the list of trusted digestsGetTPMTrustedAttestationPublicKey
andGetInstanceInfo
functions now also acceptextraData
(userData
hashed withnonce
)Additional info
Checklist