cli: use pseudoversion and forward it into helm charts #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
katexochen
reviewed
Feb 27, 2023
malt3
approved these changes
Feb 27, 2023
katexochen
approved these changes
Feb 27, 2023
All binaries that receive a version number during build now receive a pseudoversion from hack/pseudo-version. This makes any version-dependant behavior more similar between dev and release versions. And in turn makes testing easier.
* As charts receive information like the container image from the cli it makes sense to also version the charts based on the cli version. * The pseudoversion is recalculated when running cmake. * When merging changes from release branch to main, a new commit is introduced to set the PROJECT_VERSION back to 0.0.0, so that builds include a pseudoversion.
derpsteb
force-pushed
the
feat/cli-pseudoversion
branch
from
3f7bace
to
22f3b81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
cmakeis run. This version is used to setPROJECT_VERSION, unlessPROJECT_VERSIONis set to a version other than0.0.0. The release pipeline already overwritesPROJECT_VERSION, thus this change does not interfere with the pipeline. Another commit is created when merging changes from a release branch to main that resetsPROJECT_VERSIONto0.0.0.Checklist