-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attestation: create issuer based on kernel cmd line #1355
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change so far looks good.
Do we also want to implement a chooser to select the validator for the joinservice? We would need to pass this as either an env var or a command line flag and then refactor internal/watcher/validator.go
a bit.
What do you think? A TODO would be good enough for now.
See my PR description. Related Ticket: AB#2975 |
ad2d52a
to
a0cc77a
Compare
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
a0cc77a
to
f0503ea
Compare
Proposed change(s)
choose.Issuer()
andchoose.Validator()
utility functions to create Issuer or Validator from a given oidAdditional info
choose.Validator()
will be handled in a different PRChecklist