cli: show available cli upgrades with upgrade check command

[msanft]

Proposed change(s)

• Add listing of valid CLI version upgrades with the upgrade check command
  • Upgrade is considered valid if 1) compatible with current K8s version and 2) semver is greater and has at most 1 minor version drift
• Uploading of CLI version lists and compatibility information was done in ci: add cli k8s compatibility table artifact upload to ci #1218 & ci: upload cli version list #1377

Additional info

• Possible follow-ups
  • Upgrade check command is in (urgent) need of a refactoring. Files are very large. See this AB ticket.
  • Custom version type should be used eventually. See this AB ticket.

Output of constellation upgrade check looks like:

The following updates are available with this CLI:
  Kubernetes: v1.25.7 --> v1.26.2
  CLI: v2.5.0 --> v2.6.0-pre.0.20230308113257-643afd38b347 v2.6.0-pre.0.20230309101241-15faa64ef6cc

Checklist

• Add labels (e.g., for changelog category)
• Link to Milestone

[netlify]

✅ Deploy Preview for constellation-docs canceled.

Name	Link
🔨 Latest commit	8505107
🔍 Latest deploy log	https://app.netlify.com/sites/constellation-docs/deploys/642ac058f20fca00087ed6cf

[msanft]

Reminder @msanft : Rebase to main before merging for Bazel support

[derpsteb]

Could you also extend the unittests for TestBuildString, newCompatibleCLIVersions and possibly TestUpgradeCheck?

LGTM apart from that :)

[msanft]

Could you also extend the unittests for TestBuildString, newCompatibleCLIVersions and possibly TestUpgradeCheck?

Sure, I totally forgot about the tests here. How would you go about testing newCompatibleCLIVersions? Should I put the internal calls to versionsapi behind an interface?

[derpsteb]

Yes, I think that is how I would do it :). Make versionFetcher a property of versionCollector. Then you can stub the calls to the API.

[derpsteb]

Summary of our conversation on the phone:
it probably makes more sense to only point the user to newer CLI versions in case the current CLI does not offer any more upgrades. So these are the required output formats.

Current CLI offers upgrades:

The following updates are available with this CLI:
 Kubernetes: v1.24.5 --> v1.24.12 v1.25.6
 Services: v2.4.0 --> v2.5.0
 Images: v2.4.0 --> v2.5.0
 Includes these measurements:
  4:
    expected: \"1234123412341234123412341234123412341234123412341234123412341234\"
    warnOnly: false
  8:
    expected: \"0000000000000000000000000000000000000000000000000000000000000000\"
    warnOnly: false
  9:
    expected: \"1234123412341234123412341234123412341234123412341234123412341234\"
    warnOnly: false
  11:
    expected: \"0000000000000000000000000000000000000000000000000000000000000000\"
    warnOnly: false
  12:
    expected: \"1234123412341234123412341234123412341234123412341234123412341234\"
    warnOnly: false
  13:
    expected: \"0000000000000000000000000000000000000000000000000000000000000000\"
    warnOnly: false
  15:
    expected: \"0000000000000000000000000000000000000000000000000000000000000000\"
    warnOnly: false

Current CLI offers no upgrades (apart from k8s), but newer CLIs are available:

The following updates are available with this CLI:
 Kubernetes: v1.24.5 --> v1.24.12 v1.25.6
Newer CLI versions that are compatible with your cluster are: v2.5.0.

There are newer CLIs, but none are compatible with the current k8s version:

The following updates are available with this CLI:
 Kubernetes: v1.24.5 --> v1.24.12 v1.25.6
There are newer CLIs available, however, you need to upgrade your cluster's Kubernetes version first.

No newer versions at all:

You are up to date.

[derpsteb]

The output rework looks good, but this might need some further manual testing? Currently breaks for me due to missing cli.json in the bucket, when listing the major versions.

EDIT: everything worked as expected.