cli: fix upgrade apply for image-only upgrades
#1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derpsteb
added
bug fix
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
derpsteb
force-pushed
the
fix/upgrade-image-only
branch
from
f20e501
to
f7dcdeb
Compare
This fixes a bug where `upgrade apply` fails if only the image is upgraded, due to mishandling of an empty configmap. Making stubStableClient more complex is needed since it is called with multiple configMaps now.
derpsteb
force-pushed
the
fix/upgrade-image-only
branch
from
f7dcdeb
to
d9acdbe
Compare
derpsteb
changed the title
upgrade apply for image-only upgrades
3u13r
requested changes
Mar 21, 2023
* reorder switch; use default over err != nil * separate, more descriptive error messages * remove extra components == nil check
derpsteb
added a commit
that referenced
this pull request
Mar 24, 2023
This fixes a bug where `upgrade apply` fails if only the image is upgraded, due to mishandling of an empty configmap. Making stubStableClient more complex is needed since it is called with multiple configMaps now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
upgrade applyfails if only the image version is upgraded. This is due to mishandling of an empty configmap. This is a bug that is only located within the CLI and does not affect the cluster's ability to upgrade.Checklist