Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add status command to print upgrade and version status of cluster #1520

Merged
merged 2 commits into from
Apr 3, 2023
Merged

cli: add status command to print upgrade and version status of cluster #1520

merged 2 commits into from
Apr 3, 2023

Conversation

derpsteb
Copy link
Member

Proposed change(s)

  • Add new command to check the status of an upgrade and installed versions.
  • Remove the unused restclient.
  • Make GetConstellationVersion a function, was an upgrader method before.

Expected test outputs are:

Target versions:
	Image: v1.1.0
	Kubernetes: v1.2.3
Installed service versions:
	Cilium: v1.0.0
	cert-manager: v1.0.0
	constellation-operators: v1.1.0
	constellation-services: v1.1.0
Cluster status: Node version of every node is up to date
Target versions:
	Image: v1.1.0
	Kubernetes: v1.2.3
Installed service versions:
	Cilium: v1.0.0
	cert-manager: v1.0.0
	constellation-operators: v1.1.0
	constellation-services: v1.1.0
Cluster status: Some node versions are out of date
	Image: 1/2
	Kubernetes: 1/2

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@derpsteb derpsteb added the feature This introduces new functionality label Mar 24, 2023
@derpsteb derpsteb added this to the v2.7.0 milestone Mar 24, 2023
@netlify
Copy link

netlify bot commented Mar 24, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 6fe03e7
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/642a9dc8ffd6fd0008691c65
😎 Deploy Preview https://deploy-preview-1520--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

malt3
malt3 reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm. Will perform some additional tests.

thomasten
thomasten reviewed Mar 27, 2023
View reviewed changes
Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some style suggestions by chatgpt and me

go.mod Outdated Show resolved Hide resolved
docs/docs/workflows/upgrade.md Outdated Show resolved Hide resolved
docs/docs/workflows/upgrade.md Outdated Show resolved Hide resolved
docs/docs/workflows/upgrade.md Outdated Show resolved Hide resolved
docs/docs/workflows/upgrade.md Outdated Show resolved Hide resolved
@derpsteb
Copy link
Member Author

Fix for linkchecker can be found here #1531

@derpsteb
Copy link
Member Author

derpsteb commented Apr 3, 2023

@malt3 still want to do testing? :)

@malt3
Copy link
Contributor

malt3 commented Apr 3, 2023

@malt3 still want to do testing? :)

No. LGTM!

@derpsteb
cli: add status cmd
77a870d 
The new command allows checking the status of an upgrade
and which versions are installed.
Also remove the unused restclient.
And make GetConstellationVersion a function.
@derpsteb
cli: add kubernetes pkg to interface with cluster
6fe03e7 
Previously the content of files status and upgrade within the
cloudcmd pkg did not fit cloudcmd's pkg description.
This patch introduces a separate pkg to fix that.
@derpsteb
Copy link
Member Author

derpsteb commented Apr 3, 2023

Ignoring linkchecker as it complains about gitlab.edgeless.systems. We saw that the deployment is flacky due to the rising CPU usage. Will fix in the next few days.

@derpsteb derpsteb merged commit 7c8215e into main Apr 3, 2023
@derpsteb derpsteb deleted the feat/status-cmd branch April 3, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasten thomasten thomasten left review comments

@katexochen katexochen katexochen left review comments

@malt3 malt3 malt3 approved these changes

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derpsteb @malt3 @katexochen @thomasten