cli: fix misleading error while applying kubernetes-only upgrade #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check would previously fail if e.g. `apply` did not upgrade the image, but a new image was specified in the config. This could happen if the specified image was too new, but a valid Kuberentes upgrade was specified.
derpsteb
added
bug fix
✅ Deploy Preview for constellation-docs canceled.
|
3u13r
reviewed
Apr 12, 2023
If we are not upgrading the image we may target another release image. In that case the dev-public key does not work for validation. Since the verification is not really necessary we skip it here.
3u13r
requested changes
Apr 13, 2023
daniel-weisse
approved these changes
Apr 13, 2023
katexochen
pushed a commit
that referenced
this pull request
Apr 13, 2023
* The check would previously fail if e.g. `apply` did not upgrade the image, but a new image was specified in the config. This could happen if the specified image was too new, but a valid Kuberentes upgrade was specified. * ci: fix variable expansion in e2e-upgrade call * e2e: do not verify measurement signature
katexochen
added a commit
that referenced
this pull request
Apr 13, 2023
* The check would previously fail if e.g. `apply` did not upgrade the image, but a new image was specified in the config. This could happen if the specified image was too new, but a valid Kuberentes upgrade was specified. * ci: fix variable expansion in e2e-upgrade call * e2e: do not verify measurement signature Co-authored-by: Otto Bittner <[email protected]>
msanft
pushed a commit
that referenced
this pull request
Apr 17, 2023
* The check would previously fail if e.g. `apply` did not upgrade the image, but a new image was specified in the config. This could happen if the specified image was too new, but a valid Kuberentes upgrade was specified. * ci: fix variable expansion in e2e-upgrade call * e2e: do not verify measurement signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
upgrade applywill show a misleading error message when the config specifies an invalid image upgrade and a valid Kubernetes upgrade. In that case the upgrade is applied as expected. However, the CLI prints an error like this:Error: upgrading NodeVersion: expected NodeVersion to contain <new image reference>, got <current image reference>. This patch fixes the check.Additional info
applytriggers any upgrades as expected.Checklist