Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken configuration generation #1632

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Apr 12, 2023

Issue description

When creating a Constellation on host systems that are not Linux or not amd64, constellation config generate would generate a broken microservice version:

Problems validating config file:
    image specifies an invalid version: configured version (v2.7.0) does not adhere to SemVer syntax
    microserviceVersion specifies an invalid version: configured version (v) does not adhere to SemVer syntax
Fix the invalid entries or generate a new configuration using `constellation config generate`
Error: invalid configuration

constellation-conf.yaml:

version: v2 # Schema version of this configuration file.
image: v2.7.0 # Machine image version used to create Constellation nodes.
[...]
microserviceVersion: v # Microservice version to be installed into the cluster. Defaults to the version of the CLI.
[...]

Mitigation

The error is fixed in Constellation v2.7.1.

Proposed change(s)

  • ci: prevent accidental GOOS and GOARCH confusion in host go toolchain

Additional info

  • Setting those environment variables would lead to the pseudo-version tool being built for foreign GOOS / GOARCH, leading to it not executing on the runner. This ultimately lead to the version stamping information not being emitted.

Checklist

  • Add labels (e.g., for changelog category)

@malt3 malt3 requested a review from katexochen as a code owner April 12, 2023 08:31
@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 62cc3c4
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/64366c513cfb4800083cbd86

@malt3 malt3 added needs backport This PR needs to be backported to a previous release no changelog Change won't be listed in release changelog labels Apr 12, 2023
@malt3 malt3 requested a review from 3u13r April 12, 2023 08:34
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malt3 malt3 merged commit 52a1bb0 into main Apr 12, 2023
@malt3 malt3 deleted the fix/ci/prevent-accidential-goos-goarch branch April 12, 2023 09:05
3u13r added a commit that referenced this pull request Apr 12, 2023
@malt3 malt3 changed the title ci: prevent accidental GOOS and GOARCH confusion in host go toolchain fix microServiceVersion generated by config generate Apr 13, 2023
@katexochen katexochen added the bug fix Fixing a bug label May 2, 2023
@malt3 malt3 changed the title fix microServiceVersion generated by config generate fix broken configuration generation May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a bug needs backport This PR needs to be backported to a previous release no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants