Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: force-delete Azure resource group #1667

Merged
merged 3 commits into from
Apr 19, 2023
Merged

cli: force-delete Azure resource group #1667

merged 3 commits into from
Apr 19, 2023

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Apr 17, 2023 •
edited
Loading

Proposed change(s)

  • Disable the prevent_deletion_if_contains_resources of the Azure Terraform provider. This fixes the issues created by the failure anomaly detector. This can be changed once the issue gets addressed by Microsoft.
  • Add docs on the behaviour in the case of additional resources being added manually into the resource group (they are also deleted by constellation iam destroy)

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Apr 17, 2023
@msanft msanft added this to the v2.8.0 milestone Apr 17, 2023
@netlify
Copy link

netlify bot commented Apr 17, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 96c59d4
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/643d2caf8777880008c638e7

@msanft msanft force-pushed the feat/cli/azure-rg-deletion branch from fde9c88 to 9c6217d Compare April 17, 2023 11:11
@msanft msanft marked this pull request as ready for review April 17, 2023 11:53
katexochen
katexochen approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@katexochen katexochen removed the no changelog Change won't be listed in release changelog label Apr 17, 2023
@katexochen
Copy link
Member

We should list this change in the changelog, maybe in category 'other changes'.

@msanft msanft merged commit 3031d39 into main Apr 19, 2023
@msanft msanft deleted the feat/cli/azure-rg-deletion branch April 19, 2023 06:30
@msanft msanft added the needs backport This PR needs to be backported to a previous release label Apr 27, 2023
katexochen pushed a commit that referenced this pull request Apr 27, 2023
@msanft @katexochen
cli: force-delete Azure resource group (#1667)
1c716e1 
* force-delete Azure resource group

* were not -> weren't

* fix typo
katexochen added a commit that referenced this pull request Apr 27, 2023
@katexochen @msanft
cli: force-delete Azure resource group (#1667)
dd67a42 
* force-delete Azure resource group
* were not -> weren't
* fix typo

Co-authored-by: Moritz Sanft <[email protected]>
@katexochen katexochen added no changelog Change won't be listed in release changelog bug fix Fixing a bug labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasten thomasten thomasten approved these changes

@katexochen katexochen katexochen approved these changes

Assignees
No one assigned
Labels
bug fix Fixing a bug needs backport This PR needs to be backported to a previous release no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msanft @katexochen @thomasten