cli: create namespaced folders for upgrade backups #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource names are only unique per kind+ns. Without this patch it might happen that there are two resources with the same name in different namespaces. Upgrade might fail in that case.
derpsteb
added
bug fix
✅ Deploy Preview for constellation-docs canceled.
|
katexochen
added
needs backport
We sometimes run older CLI versions in the CI. Those versions may not support the flag.
derpsteb
force-pushed
the
fix/cli/upgrade-backups
branch
from
1564b4b
to
76b551a
Compare
malt3
approved these changes
May 2, 2023
katexochen
added a commit
that referenced
this pull request
May 2, 2023
Resource names are only unique per kind+ns. Without this patch it might happen that there are two resources with the same name in different namespaces. Upgrade might fail in that case. Co-authored-by: Otto Bittner <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
upgrade applywould fail while creating the local resource backups. This is because files are dumped into one folder with the resource name as file name. This is fixed by creating paths with this pattern:constellation-upgrade/backups/<kind>/<namespace>/<name>.yaml.Additional info
Checklist