Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: OpenStack encrypted csi block storage (cinder) #1771

Merged
merged 2 commits into from
May 17, 2023
Merged

cli: OpenStack encrypted csi block storage (cinder) #1771

merged 2 commits into from
May 17, 2023

Conversation

m1ghtym0
Copy link
Member

@m1ghtym0 m1ghtym0 commented May 16, 2023 •
edited
Loading

Proposed change(s)

  • cli: OpenStack encrypte csi block storage (cinder)

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@m1ghtym0 m1ghtym0 added the feature This introduces new functionality label May 16, 2023
@m1ghtym0 m1ghtym0 requested a review from malt3 May 16, 2023 08:23
@netlify
Copy link

netlify bot commented May 16, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit bfbf1a2
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6464bf5e29ff0e00089e3b3b

@malt3 malt3 self-assigned this May 17, 2023
malt3
malt3 reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I'm struggling with the testing environment. Will approve as soon as I can test this.

@katexochen katexochen removed their request for review May 17, 2023 10:45
@m1ghtym0 m1ghtym0 merged commit 6252193 into main May 17, 2023
@m1ghtym0 m1ghtym0 deleted the feat/openstack/cinder branch May 17, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malt3 malt3 malt3 approved these changes

@derpsteb derpsteb Awaiting requested review from derpsteb derpsteb is a code owner

@3u13r 3u13r Awaiting requested review from 3u13r 3u13r is a code owner

Assignees

@malt3 malt3

Labels
feature This introduces new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1ghtym0 @malt3