attestation: add awsSEVSNP as new variant
#1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derpsteb
requested review from
daniel-weisse,
thomasten,
katexochen and
3u13r
as code owners
✅ Deploy Preview for constellation-docs canceled.
|
daniel-weisse
requested changes
Jun 9, 2023
internal/attestation/aws/snp/snp.go
Outdated
Comment on lines
7
to
15
| /* | ||
| --------- WARNING! --------- | ||
| THIS PACKAGE DOES CURRENTLY NOT IMPLEMENT ANY SNP ATTESTATION. | ||
| It exists to implement required interfaces while implementing other parts of the AWS SNP attestation variant within Constellation. | ||
| ---------------------------- | ||
|
|
||
| # SNP |
There was a problem hiding this comment.
Suggested change
| /* | |
| --------- WARNING! --------- | |
| THIS PACKAGE DOES CURRENTLY NOT IMPLEMENT ANY SNP ATTESTATION. | |
| It exists to implement required interfaces while implementing other parts of the AWS SNP attestation variant within Constellation. | |
| ---------------------------- | |
| # SNP | |
| /* | |
| --------- WARNING! --------- | |
| THIS PACKAGE DOES CURRENTLY NOT IMPLEMENT ANY SNP ATTESTATION. | |
| It exists to implement required interfaces while implementing other parts of the AWS SNP attestation variant within Constellation. | |
| ---------------------------- | |
| # SNP |
Otherwise the formatting looks weird on the docs site.
This doc comment also still contains a lot of Azure specific information which should be updated for AWS
There was a problem hiding this comment.
I removed some Azure specific abbreviation from the bottom. Not sure what else you mean. Would be great if you could highlight that on your next pass if you still see something.
This makes the pkg's purpose more visible through it's import path.
This is preparation for adding snp attesation.
For now the implementations in aws/nitrotpm and aws/snp are identical. They both contain the aws/nitrotpm impl. A separate commit will add the actual attestation logic.
fix readme link
fix config_test.go
add image measurements
* do not extend debugLogger interface * use cmd.PrintErr to print warnings * adapt comments * do not use log.fatalf
daniel-weisse
approved these changes
Jun 9, 2023
derpsteb
force-pushed
the
feat/aws/snp-attestation
branch
from
f6b83e9
to
de3ce70
Compare
elchead
pushed a commit
that referenced
this pull request
Jun 12, 2023
* variant: move into internal/attestation * attesation: move aws attesation into subfolder nitrotpm * config: add aws-sev-snp variant * cli: add tf option to enable AWS SNP For now the implementations in aws/nitrotpm and aws/snp are identical. They both contain the aws/nitrotpm impl. A separate commit will add the actual attestation logic.
2 tasks
derpsteb
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
awsSEVSNPas attestation variant. This does not include the attestation implementation. Instead, the standard awsNitroTPM attestation is used. A warning is printed during init and the config includes a warning comment.awsSEVSNPas value forattestation.internal/varianttointernal/attestation/variantAdditional info
ref/feat-aws-snp-attestation/stream/debug/v2.8.0-pre.0.20230608071806-582d3a0b5009Checklist