config: drop support for deprecated Azure's service principal authentication #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
elchead
force-pushed
the
config/azure/remove-app-client-id
branch
from
4b99dab
to
04d20cf
Compare
derpsteb
reviewed
Jun 12, 2023
elchead
changed the title
derpsteb
reviewed
Jun 13, 2023
derpsteb
reviewed
Jun 13, 2023
derpsteb
reviewed
Jun 13, 2023
|
Looks a lot cleaner now. I like it! 👍 |
|
linker fails due to timeout of external HTTP link. can ignore |
elchead
changed the title
derpsteb
reviewed
Jun 13, 2023
derpsteb
reviewed
Jun 13, 2023
derpsteb
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
looks good from my side, maybe @3u13r wants to take a quick look. he is more familiar with the topic.
Please update the PR description to give more context. This should be understandable by a user who clicked the PR link while reading the changelog.
Co-authored-by: Otto Bittner <[email protected]>
|
Please add some more information to the PR description for users who are redirected from the changelog. They can't see the linked ticket. We probably describe the topic in the docs somewhere. |
elchead
changed the title
msanft
pushed a commit
that referenced
this pull request
Jun 19, 2023
…ication (#1906) * invalidate app client id field for azure and provide info * remove TestNewWithDefaultOptions case * fix test * remove appClientID field * remove client secret + rename err * remove from docs * otto feedback * update docs * delete env test in cfg since no envs set anymore * Update dev-docs/workflows/github-actions.md Co-authored-by: Otto Bittner <[email protected]> * WARNING to stderr * fix check --------- Co-authored-by: Otto Bittner <[email protected]>
msanft
pushed a commit
that referenced
this pull request
Jun 19, 2023
…ication (#1906) * invalidate app client id field for azure and provide info * remove TestNewWithDefaultOptions case * fix test * remove appClientID field * remove client secret + rename err * remove from docs * otto feedback * update docs * delete env test in cfg since no envs set anymore * Update dev-docs/workflows/github-actions.md Co-authored-by: Otto Bittner <[email protected]> * WARNING to stderr * fix check --------- Co-authored-by: Otto Bittner <[email protected]>
msanft
pushed a commit
that referenced
this pull request
Jun 20, 2023
…ication (#1906) * invalidate app client id field for azure and provide info * remove TestNewWithDefaultOptions case * fix test * remove appClientID field * remove client secret + rename err * remove from docs * otto feedback * update docs * delete env test in cfg since no envs set anymore * Update dev-docs/workflows/github-actions.md Co-authored-by: Otto Bittner <[email protected]> * WARNING to stderr * fix check --------- Co-authored-by: Otto Bittner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is the last step to completely deprecate the old method of handling Azure service accounts (see more on the migration here). With the next release the CLI enforces the user to update its configuration to the new unified UAMI.
Proposed change(s)
Additional info
AB#2967
Checklist