-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: fail fast when CLI and Constellation versions don't match #1972
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
Should this be a |
bug fix seems fine to me |
is it correct that the microservice version should be exactly equal to the CLI and the image version only major minor equal (ignoring the commit hash suffix) @malt3 |
Here is the true canonical answer to that, which we could document somewhere. Not sure what the best place would be: Target microservice version (the version that is referenced in the config during Target kubernetes version (the version that is referenced in the config during Target image version (the version that is referenced in the config during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. Otherwise lgtm
Thanks for the extensive answer which I definitely want to document. |
Putting this into the |
@malt3 is the new doc place fine? |
Yes! thank you. |
relabeling to put this into the "Other changes" category. Feels more like a UX improvement than a bug fix. |
Context
We don't support creating e.g. a 2.7.1 Constellation with e.g. the 2.8.0. CLI.
More precisely: The to-be-created Constellation version must always match the CLI's version, down to the patch version.
We don't want to forbid using/loading an old config since this is needed for e.g. the upgrade process.
But we want to fail fast if the user tries to
constellation create
orconstellation init
a Constellation.Mismatches can be found by comparing the CLI's version against the
microserviceVersion
andimage
version of the config. Then we want to fail hard onconstellation create
andconstellation init
with a corresponding error which states that there is a mismatch and that the corresponding version to the config must be downloaded or the version in the config must be updated.Creating a Constellation v2.7.1 (nodes and microservices) with a v2.8.0 CLI (Darwin, ARM64) gives the following errror:
Proposed change(s)
create
andinit
to fail early when the versions don't match.Related issue
Checklist