Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add iam:DeletePolicyVersion #2111

Merged
merged 2 commits into from
Jul 18, 2023
Merged

doc: add iam:DeletePolicyVersion #2111

merged 2 commits into from
Jul 18, 2023

Conversation

elchead
Copy link
Contributor

@elchead elchead commented Jul 17, 2023

Context

I stumbled upon a missing permission to delete my IAM role.
MicrosoftTeams-image

Proposed change(s)

  • add missing permission to documentation
  • permission was already added to dev profile and fixed the error

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@elchead elchead requested a review from thomasten as a code owner July 17, 2023 15:59
@elchead elchead requested a review from malt3 July 17, 2023 15:59
@elchead elchead changed the title document iam:DeletePolicyVersion doc: add iam:DeletePolicyVersion Jul 17, 2023
malt3
malt3 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also copy this into older versions of the docs? Otherwise LGTM

@netlify
Copy link

netlify bot commented Jul 17, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 6cf4d1f
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/64b62bfe82e0bf000888218d
😎 Deploy Preview https://deploy-preview-2111--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elchead elchead merged commit 320fd4b into main Jul 18, 2023
@elchead elchead deleted the fix/aws/delete-iam branch July 18, 2023 08:24
@elchead elchead added the documentation Improvements or additions to documentation label Aug 14, 2023
@elchead elchead added this to the v2.10.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanft msanft msanft approved these changes

@malt3 malt3 malt3 approved these changes

@thomasten thomasten Awaiting requested review from thomasten thomasten is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elchead @malt3 @msanft