cli: retry during upgrade when node image update fails due to conflict error #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
elchead
force-pushed
the
fix/kubernetes/node-img-update-retry
branch
2 times, most recently
from
3475303
to
ab60292
Compare
derpsteb
approved these changes
Jul 24, 2023
elchead
force-pushed
the
fix/kubernetes/node-img-update-retry
branch
from
ab60292
to
685b345
Compare
elchead
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
During upgrade apply the write to our NodeVersion custom resource may fail because the constellation-operator updated the status field of the resource between read and write.
Our operator solves this by retrying the write if it encounters a write conflict [1]. The CLI's upgrade apply code [2] should use the same pattern.
[1] https://github.com/edgelesssys/constellation/blob/main/operators/constellation-node-operator/controllers/joiningnode_controller.go#L65-L78
[2] https://github.com/edgelesssys/constellation/blob/main/cli/internal/kubernetes/upgrade.go#L253
Proposed change(s)
Related issue
Checklist