cli: fix incorrect file path for master secret during upgrades when using workspace flag #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Weiße <[email protected]>
✅ Deploy Preview for constellation-docs canceled.
|
katexochen
added
needs backport
elchead
approved these changes
Aug 16, 2023
elchead
pushed a commit
that referenced
this pull request
Aug 16, 2023
…sing workspace flag (#2249) Signed-off-by: Daniel Weiße <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
PathPrefixer.PrefixPathshould only be used to prefix printable paths (paths that are not used to access files).constellation upgrade applyused thePathPrefixerto add a workspace prefix when loading the master secret when upgrading a cluster's helm charts.This causes errors when using the
--workspace/-Cflag duringconstellation upgrade apply.Proposed change(s)
PathPrefixerwhen accessing the master secretPathPrefixer'sPrefixPathmethod toPrefixPrintablePathand add additional warnings to further highlight this function should only be used to generate printable paths.