cli: fix upgrade by passing placeholder values for images #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
elchead
added
needs backport
elchead
changed the title
3u13r
requested changes
Aug 16, 2023
| @@ -23,13 +23,13 @@ func TerraformUpgradeVars(conf *config.Config) (terraform.Variables, error) { | |||
| // The image is updates via our operator. | |||
There was a problem hiding this comment.
Update suggestion for the line above:
// Note that we don't pass any real image as imageRef, as we ignore changes to the image in the terraform.
// Still, the terraform variable verification must accept the values.
// For AWS, we enforce some basic constraints on the image variable.
// For Azure, the provider enforces that the source_image_id is not empty.
// For GCP, any placeholder works.
daniel-weisse
approved these changes
Aug 16, 2023
|
running all E2E upgrades before merging and starting new release |
elchead
force-pushed
the
fix/terraform/upgrade-image-ref
branch
from
432745c
to
9321881
Compare
|
Converted this to a draft until the azure upgrade tests passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes a bug from #2211.
The current TF validation on AWS prevents an empty value set during an upgrade. Similarly, Azure also doesn't allow empty strings.
Proposed change(s)
Checklist