Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: move idle and nosmt to aws-only images #2297

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

derpsteb
Copy link
Member

@derpsteb derpsteb commented Sep 1, 2023

Context

Amends #2291. We don't want these options on other CSPs. This is temporary until AWS fixed some background issues.

Proposed change(s)

  • Move idle=poll mitigations=auto options to aws-only config

Additional info

@derpsteb derpsteb requested a review from malt3 as a code owner September 1, 2023 10:49
malt3
malt3 previously approved these changes Sep 1, 2023
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we will test the actual behavior of mkosi and not take any chances.

@malt3 malt3 dismissed their stale review September 1, 2023 13:31

behavior needs to be tested

We don't want these options on other CSPs. This is temporary until AWS
fixed some background issues.
We need to set the option we want to set differently on each provider
once per provider as we need to keep some of the options we set with
higher priority.
@derpsteb
Copy link
Member Author

derpsteb commented Sep 4, 2023

Manual test on AWS succeeded. cat /proc/cmdline showed that the expected arguments are set.

Smoketest on Azure: https://github.com/edgelesssys/constellation/actions/runs/6072057303

@derpsteb derpsteb merged commit cb934ed into main Sep 4, 2023
33 checks passed
@derpsteb derpsteb deleted the fix/image/smt-aws-only branch September 4, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants