Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add observability page #2384

Merged
merged 9 commits into from
Oct 4, 2023
Merged

docs: add observability page #2384

merged 9 commits into from
Oct 4, 2023

Conversation

m1ghtym0
Copy link
Member

@m1ghtym0 m1ghtym0 commented Sep 27, 2023 •
edited
Loading

Proposed change(s)

  • Add page about observability to the docs
  • Focus on Constellation not application/container level

Additional information

  • HOLD: Will update the 2.11 docs, once this has been reviewed
  • Please check if there is anything missing/wrong from your perspective @msanft @malt3 @3u13r

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@m1ghtym0 m1ghtym0 added documentation Improvements or additions to documentation hold This cannot be merged right now labels Sep 27, 2023
@netlify
Copy link

netlify bot commented Sep 27, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 3add76b
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/651d133d7c9b3700082df051
😎 Deploy Preview https://deploy-preview-2384--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@msanft
Copy link
Contributor

msanft commented Sep 27, 2023

I think this is a great overview of the observability possibilities. I can't think of any more things that would be of interest here, but I don't really know what a customer might want in regards to observability either. Maybe Malte can say more regarding that.

3u13r
3u13r approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
thomasten
thomasten requested changes Sep 30, 2023
View reviewed changes
docs/docs/architecture/observability.md Show resolved Hide resolved
docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
docs/docs/architecture/observability.md Outdated Show resolved Hide resolved
@m1ghtym0 m1ghtym0 removed the hold This cannot be merged right now label Oct 4, 2023
@m1ghtym0 m1ghtym0 merged commit 7c76592 into main Oct 4, 2023
7 checks passed
@m1ghtym0 m1ghtym0 deleted the feat/docs/observability branch October 4, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanft msanft msanft left review comments

@thomasten thomasten thomasten approved these changes

@3u13r 3u13r 3u13r approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m1ghtym0 @msanft @3u13r @thomasten