Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: extend filestash example with more regions #2445

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Conversation

derpsteb
Copy link
Member

Context

Extend docs slightly.

Proposed change(s)

  • Add all currently defined regions to filestash example.
  • Add more explanation what to do with the example.

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@derpsteb derpsteb added the documentation Improvements or additions to documentation label Oct 11, 2023
@derpsteb derpsteb added this to the v2.13.0 milestone Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 07c8c2c
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6527e29655554f0008f3d2c8
😎 Deploy Preview https://deploy-preview-2445--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's what I had in mind.
Remember to apply suggestions to both files.

docs/docs/getting-started/examples/filestash-s3proxy.md Outdated Show resolved Hide resolved
docs/docs/getting-started/examples/filestash-s3proxy.md Outdated Show resolved Hide resolved
docs/docs/getting-started/examples/filestash-s3proxy.md Outdated Show resolved Hide resolved
docs/docs/getting-started/examples/filestash-s3proxy.md Outdated Show resolved Hide resolved
docs/docs/getting-started/examples/filestash-s3proxy.md Outdated Show resolved Hide resolved
Also add a bit more explanation what to do with the example.
Otherwise the DNS cert isn't valid for the newly added
regions
@derpsteb
Copy link
Member Author

Ignoring CI failures as they are not related to this PR.

@derpsteb derpsteb merged commit 1e13da3 into main Oct 12, 2023
5 of 7 checks passed
@derpsteb derpsteb deleted the docs/s3proxy/filestash branch October 12, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants