-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: add GCP CCM permissions for internal LBs #2474
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
Coverage report
|
name: cluster-admin | ||
subjects: | ||
- kind: ServiceAccount | ||
name: cloud-provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide an e2e test for this?
From what I can tell, there is no ServiceAccount called cloud-provider
in our set up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E, gcp, 1.27, lb, 1:1 https://github.com/edgelesssys/constellation/actions/runs/6571600139
Or do you mean that I should add an E2E test which explicitly tests this feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, just running the e2e test is fine.
But I'm still wondering who is supposed to consume this role binding as the referenced ServiceAccount does not exist (at least in our Helm charts)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a default service account which simply exists in K8s and some (default) permissions have been removed from it. If it does not exists anymore, we'll have to create it, but currently it seems to work.
Context
The GCP CCM hard-codes an outdated ClusterRole. We need to give it the required permissions again. See: kubernetes/cloud-provider-gcp#611
Proposed change(s)
Additional info
Checklist