Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: refer to apply command instead of init or upgrade apply #2487

Merged
merged 2 commits into from
Oct 27, 2023
Merged

docs: refer to apply command instead of init or upgrade apply #2487

merged 2 commits into from
Oct 27, 2023

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Oct 20, 2023 •
edited by azure-boards bot
Loading

Context

Docs should not use deprecated commands

Proposed change(s)

  • refer to apply command instead of init or upgrade apply

Additional info

  • AB#3499
  • The asciinema should be updated at some point to also make use of apply instead of init

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@daniel-weisse daniel-weisse added the documentation Improvements or additions to documentation label Oct 20, 2023
@daniel-weisse daniel-weisse added this to the v2.13.0 milestone Oct 20, 2023
3u13r
3u13r approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thomasten
thomasten requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two more inits in workflows/terminate.md and architecture/orchestration.md

@elchead
Copy link
Contributor

elchead commented Oct 20, 2023

lgtm besides thomas comment.

@daniel-weisse daniel-weisse force-pushed the feat/cli/apply-command branch 2 times, most recently from 2c5feaf to cb27cf7 Compare October 24, 2023 13:41
@derpsteb derpsteb removed their request for review October 26, 2023 06:25
Base automatically changed from feat/cli/apply-command to main October 26, 2023 13:59
@netlify
Copy link

netlify bot commented Oct 26, 2023

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 9fb086a
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/653a711894a0760007df74c6
😎 Deploy Preview https://deploy-preview-2487--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

Coverage report

Package Old New Trend
e2e/internal/upgrade [no test files] [no test files] 🚧

@daniel-weisse daniel-weisse merged commit f4bfbe3 into main Oct 27, 2023
11 checks passed
@daniel-weisse daniel-weisse deleted the feat/docs/apply-command branch October 27, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasten thomasten thomasten approved these changes

@3u13r 3u13r 3u13r approved these changes

@malt3 malt3 malt3 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@daniel-weisse @elchead @malt3 @3u13r @thomasten