Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align self-managed infrastructure docs with e2e worfklow #2525

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Oct 27, 2023

Context

Self-managed infrastructure docs missed a few outputs that have to be present in the state file before constellation apply, as well as the necessary patch of the MAA provider policy.

Proposed change(s)

  • Update the docs to be aligned with what we do in our e2e workflow.

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the documentation Improvements or additions to documentation label Oct 27, 2023
@msanft msanft added this to the v2.13.0 milestone Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 0782d37
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/653f705593d6e800086a8853
😎 Deploy Preview https://deploy-preview-2525--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/docs/workflows/create.md Outdated Show resolved Hide resolved
docs/docs/workflows/create.md Outdated Show resolved Hide resolved
docs/docs/workflows/create.md Outdated Show resolved Hide resolved
docs/docs/workflows/create.md Outdated Show resolved Hide resolved
docs/docs/workflows/create.md Outdated Show resolved Hide resolved
docs/docs/workflows/create.md Outdated Show resolved Hide resolved
docs/docs/workflows/create.md Outdated Show resolved Hide resolved
```bash
https://github.com/edgelesssys/constellation/tree/<VERSION>
cd constellation/hack/maa-patch
go run . $(terraform output attestationURL | jq -r)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure CLI doesn't support this operation, does it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically, it does, but it would require a fairly long script that we would have to potentially maintain along the code in our CLI, why I opted to share the code and create a tool instead.

docs/docs/workflows/create.md Outdated Show resolved Hide resolved
Signed-off-by: Moritz Sanft <[email protected]>
@msanft msanft merged commit 21cfb40 into main Oct 30, 2023
5 of 7 checks passed
@msanft msanft deleted the fix/docs/self-managed-nfra branch October 30, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants