Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] cli: fix incorrect filepath separator causing upgrades to fail #2562

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

daniel-weisse
Copy link
Member

Proposed change(s)

  • Fix incorrect usage of path.Dir() (instead of filepath.Dir()) that breaks directory backups for the Constellation CLI on Windows.
    • This effectively made the CLI unable to run constellation upgrade apply on Windows systems
    • Detected because we run the Terraform state backup as part of constellation apply, which is called during the initialization process

Additional info

@daniel-weisse daniel-weisse added the bug fix Fixing a bug label Nov 8, 2023
@daniel-weisse daniel-weisse added this to the v2.13.0 milestone Nov 8, 2023
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 27196a4
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/654b39b29b63c200087f08f3

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Coverage report

Package Old New Trend
internal/file 89.40% 89.40% ↔️

@daniel-weisse daniel-weisse merged commit 32706f5 into main Nov 8, 2023
11 checks passed
@daniel-weisse daniel-weisse deleted the fix/cli/windows-terraform-create branch November 8, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants