Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update cert manager to 1.12.6 #2700

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Dec 11, 2023

Context

Proposed change(s)

  • Bump cert manager to 1.12.6 (see `generateCertManager.sh)

Additional info

  • Any additional information or context

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@3u13r 3u13r added the feature This introduces new functionality label Dec 11, 2023
@3u13r 3u13r requested a review from derpsteb as a code owner December 11, 2023 12:24
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 6d514f1
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/657c5298cc869e0007a99962
😎 Deploy Preview https://deploy-preview-2700--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@3u13r 3u13r force-pushed the deps/bump/cert-manager-1.13.2 branch 4 times, most recently from bf478cb to d61b7ba Compare December 12, 2023 16:14
@3u13r 3u13r changed the title deps: Update cert manager to 1.13.2 deps: Update cert manager to 1.12.6 Dec 12, 2023
@daniel-weisse
Copy link
Member

daniel-weisse commented Dec 13, 2023

Why are we upgrading to v1.12 instead of v1.13?
Are there any compatibility issues with that version?

@3u13r
Copy link
Member Author

3u13r commented Dec 13, 2023

Why are we upgrading to v1.12 instead of v1.13?
Are there any compatibility issues with that version?

From https://cert-manager.io/docs/releases/upgrading/upgrading-1.12-1.13:

IMPORTANT NOTE: If upgrading from a version below v1.12, upgrade to the latest v1.12 release 
before upgrading to v1.13. Otherwise, some certificates may be unexpectedly re-issued 
(see https://github.com/cert-manager/cert-manager/issues/6494#issuecomment-1816112309)

@3u13r 3u13r added this to the v2.14.0 milestone Dec 13, 2023
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run the upgrade test and make sure things still work?
lgtm otherwise

internal/constellation/helm/helm_test.go Outdated Show resolved Hide resolved
@3u13r
Copy link
Member Author

3u13r commented Dec 14, 2023

@3u13r 3u13r force-pushed the deps/bump/cert-manager-1.13.2 branch from 4083dce to 6d514f1 Compare December 15, 2023 13:20
Copy link
Contributor

Coverage report

Package Old New Trend
internal/constellation/helm 52.70% 52.70% ↔️

@3u13r 3u13r merged commit 0111b6d into main Dec 15, 2023
10 checks passed
@3u13r 3u13r deleted the deps/bump/cert-manager-1.13.2 branch December 15, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This introduces new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants