terraform-provider: fix parsing api_server_cert_sans
#2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
3u13r
changed the title
api_server_cert_sansapi_server_cert_sans
msanft
requested changes
Dec 20, 2023
msanft
changed the title
api_server_cert_sansapi_server_cert_sans
msanft
requested changes
Dec 20, 2023
terraform-provider-constellation/examples/full/azure_cluster.tf
Outdated
Show resolved
Hide resolved
msanft
approved these changes
Dec 20, 2023
3u13r
force-pushed
the
fix/tf-provider/cert-sans
branch
from
cbb2d1c
to
53ac030
Compare
Coverage report
|
elchead
approved these changes
Dec 21, 2023
| @@ -70,6 +70,7 @@ module "aws_infrastructure" { | |||
| image_id = data.constellation_image.bar.image.reference | |||
| region = local.region | |||
| zone = local.zone | |||
| internal_load_balancer = false | |||
| debug = false | |||
There was a problem hiding this comment.
should we remove debug, since we don't really support this for customers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Proposed change(s)
Additional info
Checklist