Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STACKIT Kubernetes API load balancing #2925

Merged
merged 1 commit into from
Feb 22, 2024
Merged

STACKIT Kubernetes API load balancing #2925

merged 1 commit into from
Feb 22, 2024

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Feb 20, 2024 •
edited
Loading

Context

Proposed change(s)

  • Add stackit load balancer in OpenStack Terraform
  • Get LoadBalancerEndpoint in OpenStack from the IMDS API

Note that once we want to support more openstack implementation than StackIT, then we should make StackIT its own provider.

To test this PR you need to be authenticated with the StackIT API. You can follow one of the ways described here: https://registry.terraform.io/providers/stackitcloud/stackit/latest/docs#authentication

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@netlify Netlify
Copy link

netlify bot commented Feb 20, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit de275ba
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65d772425ac5c20009e6c5f4

@3u13r 3u13r force-pushed the feat/stackit/k8s-api-load-balancer branch from f68d46d to e90b51c Compare February 20, 2024 16:52
@3u13r 3u13r added this to the v2.16.0 milestone Feb 20, 2024
@3u13r 3u13r added the feature This introduces new functionality label Feb 20, 2024
@3u13r 3u13r force-pushed the feat/stackit/k8s-api-load-balancer branch 2 times, most recently from 8e7e55c to 12d30b9 Compare February 21, 2024 11:07
@3u13r 3u13r marked this pull request as ready for review February 21, 2024 11:24
@malt3 malt3 changed the title StackIT Kubernetes API load balancing STACKIT Kubernetes API load balancing Feb 21, 2024
malt3
malt3 reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Nice work! I'll perform a final test once we have this rebased on #2910.

cli/internal/cloudcmd/tfvars.go Outdated Show resolved Hide resolved
cli/internal/terraform/variables.go Outdated Show resolved Hide resolved
cli/internal/terraform/variables_test.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
terraform/infrastructure/openstack/variables.tf Outdated Show resolved Hide resolved
daniel-weisse
daniel-weisse approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really comment on the Terraform changes.
Updates to my owned file look good to me

internal/constellation/helm/overrides.go Outdated Show resolved Hide resolved
terraform/infrastructure/openstack/main.tf Outdated Show resolved Hide resolved
elchead
elchead approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it but the TF code changes lgtm.

@3u13r 3u13r force-pushed the feat/stackit/k8s-api-load-balancer branch from 12d30b9 to 1502ac9 Compare February 22, 2024 13:40
malt3
malt3 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this successfully.

terraform/infrastructure/openstack/modules/stackit_loadbalancer/main.tf Outdated Show resolved Hide resolved
terraform/infrastructure/openstack/main.tf Outdated Show resolved Hide resolved
@3u13r 3u13r force-pushed the feat/stackit/k8s-api-load-balancer branch from 1502ac9 to de275ba Compare February 22, 2024 16:11
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cloudcmd 19.50% 19.50% 🚧
cli/internal/terraform 57.30% 57.30% ↔️
internal/cloud/openstack 89.60% 86.90% ↘️
internal/config 69.00% 69.10% ↗️
internal/constellation/helm 34.10% 34.10% 🚧
terraform [no test files] [no test files] 🚧

@3u13r 3u13r merged commit 2a61861 into main Feb 22, 2024
9 checks passed
@3u13r 3u13r deleted the feat/stackit/k8s-api-load-balancer branch February 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@elchead elchead elchead approved these changes

@malt3 malt3 malt3 approved these changes

@derpsteb derpsteb Awaiting requested review from derpsteb derpsteb is a code owner

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@3u13r @malt3 @elchead @daniel-weisse