Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: remove immediate node status printing #3351

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

burgerdev
Copy link
Contributor

Context

The upgrade test interleaves stdout messages and test logs, making the output harder to read than necessary.

https://github.com/edgelesssys/constellation/actions/runs/10791721941/job/29952302050#step:19:20029

Proposed change(s)

  • Don't print to stdout, only to log.

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@burgerdev burgerdev added the no changelog Change won't be listed in release changelog label Sep 11, 2024
@burgerdev burgerdev added this to the v2.19.0 milestone Sep 11, 2024
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 5f29372
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/66e16293dae6220008e5913e

Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev burgerdev merged commit e077eaf into main Sep 12, 2024
11 checks passed
@burgerdev burgerdev deleted the burgerdev/upgrade-test-output branch September 12, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants