Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upgrade agent for automatic version updates #745

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Add upgrade agent for automatic version updates #745

merged 1 commit into from
Dec 25, 2022

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Dec 7, 2022 •
edited
Loading

Proposed change(s)

  • Add an upgrade agent for updating Kubernetes versions while providing a strict interface to keep minimal access into the machine.

Additional info

  • Upgrade agent should only be deployed to the control plane nodes.
  • Server is being exposed via a UDS which limits it to only be accessible locally.

Checklist

@netlify
Copy link

netlify bot commented Dec 7, 2022

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit a7f16c7
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63908d765bf8210008302d6f
😎 Deploy Preview https://deploy-preview-745--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit f48e68d
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63a88ad5f83a260007366934

3u13r
3u13r requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for now. Some minor requests. Of course, this still needs the /cmd part and needs to expose the server through a socket.

upgrade-agent/server.go Outdated Show resolved Hide resolved
upgrade-agent/server.go Outdated Show resolved Hide resolved
upgrade-agent/install.go Outdated Show resolved Hide resolved
upgrade-agent/upgradeproto/upgrade.proto Outdated Show resolved Hide resolved
upgrade-agent/install.go Outdated Show resolved Hide resolved
@msanft
Copy link
Contributor Author

msanft commented Dec 8, 2022

Also, i wondered about whether the agent needs to be secured / use TLS for the connection?

@3u13r
Copy link
Member

3u13r commented Dec 8, 2022 •
edited
Loading

Also, i wondered about whether the agent needs to be secured / use TLS for the connection?

No it does not. The server is only reachable locally which is enforced by the fact that it only exposes a UDS (Unix Domain Socket).

@3u13r
Copy link
Member

3u13r commented Dec 8, 2022

Overall architecture looks good! Currently, I don't see anything large missing. I think we can already add this in the CMakeLists.txt. We can integrate this in the CI and Image in a separate PR.

@msanft msanft changed the title WIP: #AB2544 Add upgrade agent for automatic version updates AB#2544 Add upgrade agent for automatic version updates Dec 8, 2022
@msanft msanft marked this pull request as ready for review December 12, 2022 08:25
3u13r
3u13r requested changes Dec 12, 2022
View reviewed changes
bootstrapper/internal/kubernetes/k8sapi/k8sutil.go Outdated Show resolved Hide resolved
upgrade-agent/cmd/main.go Outdated Show resolved Hide resolved
upgrade-agent/server.go Outdated Show resolved Hide resolved
upgrade-agent/server.go Outdated Show resolved Hide resolved
daniel-weisse
daniel-weisse reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

upgrade-agent/server.go Outdated Show resolved Hide resolved
upgrade-agent/server.go Outdated Show resolved Hide resolved
daniel-weisse
daniel-weisse approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@m1ghtym0 m1ghtym0 mentioned this pull request Dec 16, 2022
Closed
9 tasks
@msanft msanft removed the request for review from katexochen December 19, 2022 12:16
3u13r
3u13r approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last typo. Please also fix the CI linter checks. Otherwise LGTM.

bootstrapper/internal/kubernetes/k8sapi/k8sutil.go Outdated Show resolved Hide resolved
@msanft msanft merged commit 9859b30 into main Dec 25, 2022
@msanft msanft deleted the feat/upgradeAgent branch December 25, 2022 17:49
@msanft msanft restored the feat/upgradeAgent branch December 25, 2022 17:49
@thomasten thomasten changed the title AB#2544 Add upgrade agent for automatic version updates Add upgrade agent for automatic version updates Jan 11, 2023
@msanft msanft deleted the feat/upgradeAgent branch March 10, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen left review comments

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@3u13r 3u13r 3u13r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msanft @3u13r @katexochen @daniel-weisse