Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join: make Azure instance names k8s compliant #807

Merged
merged 3 commits into from
Dec 23, 2022
Merged

join: make Azure instance names k8s compliant #807

merged 3 commits into from
Dec 23, 2022

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Dec 16, 2022 •
edited by katexochen
Loading

Proposed change(s)

  • Azure machine names contain upper case letters. K8s doesn't allow them for any resource. We already normalize them in the bootstrapper. With 2.3.0 we introduced the joiningnode CRD which is created by the JoinService. For worker nodes the entries are named after the node name from inside the CSR, which is the non-normalized Azure machine name.

Checklist

  • Check if the name also needs to be normalized in the Spec, since our node operator consumes this field. Yes.
  • Update CHANGELOG.md
  • Link to Milestone

@3u13r 3u13r added the bug fix Fixing a bug label Dec 16, 2022
@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit d5e7fde
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63a5e0bb91f1520008571df0

@3u13r 3u13r force-pushed the fix/joinservice/AzureNonCompliantNaming branch from ee49f62 to fd958a5 Compare December 16, 2022 10:46
@3u13r 3u13r marked this pull request as ready for review December 16, 2022 10:47
@3u13r 3u13r added this to the v2.4.0 milestone Dec 22, 2022
@katexochen katexochen self-assigned this Dec 23, 2022
@3u13r 3u13r force-pushed the fix/joinservice/AzureNonCompliantNaming branch from fd958a5 to 732e352 Compare December 23, 2022 16:36
katexochen
katexochen approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtsanta... 🎅

@3u13r 3u13r merged commit d1195d1 into main Dec 23, 2022
@3u13r 3u13r deleted the fix/joinservice/AzureNonCompliantNaming branch December 23, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

Assignees

@katexochen katexochen

Labels
bug fix Fixing a bug
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@3u13r @katexochen