-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade: support Kubernetes components #839
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
053d2a1
to
fc8f8d6
Compare
fc8f8d6
to
c5d5f5d
Compare
c5d5f5d
to
05611fe
Compare
Breaking change: Renaming the custom resource from |
operators/constellation-node-operator/internal/deploy/deploy.go
Outdated
Show resolved
Hide resolved
Testing works (even between two minor versions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed change(s)
NodeImage
and friends toNodeVersion
NodeVersion
NodeVersion
custom resource instead of having a separatek8s-version
ConfigMapDiscussion: Should we announce this feature in the release notes already?
My opinion: No, since it is part of the complete upgrade feature which needs to be fully implemented, documented, and tested.
How to test:
versions.go
k8s-components-sha256-ABC
ConfigMap (Download links and hashes need to match+work)NodeVersion
namednode-versioin
NodeVersion
CRD,PendingNode
CRD, andNoes
)What works best for me is to downgrade the patch version of the Kubernetes components in the
versions.go
. Then create a Constellation and upgrade to the latest patch version. This version should be visible viakubectl get nodes -A -o wide
.Checklist